PC-550: Add the ability to add bespoke text to LAs on the outcome page #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artials for existing copy. Map LA Custodian Codes to Partial locations in QuestionnaireController.
CalPinSW
commented
Jan 5, 2024
CalPinSW
changed the title
jamiehumphries
suggested changes
Jan 22, 2024
| { | ||
| return custodianCode switch | ||
| { | ||
| "2610" => "~/Views/Partials/ConfirmationLAMessage/Broadland.cshtml", |
There was a problem hiding this comment.
You haven't committed a file to this location. It looks like this should just be using the default, unless I'm misreading the ticket.
There was a problem hiding this comment.
Yes, good point. Think I got ahead of myself and added this route before we had copy for it. I'll remove this case in the switch. Obviously we could remove the switch statement until we have copy for custom ones, but I think it's worth leaving in for future use unless your opposed to it?
HerPublicWebsite/Views/Partials/ConfirmationLAMessage/Default.cshtml
Outdated
Show resolved
Hide resolved
HerPublicWebsite/Views/Partials/PendingLAMessage/Broadland.cshtml
Outdated
Show resolved
Hide resolved
HerPublicWebsite/Views/Partials/PendingLAMessage/Broadland.cshtml
Outdated
Show resolved
Hide resolved
HerPublicWebsite/Views/Partials/PendingLAMessage/Default.cshtml
Outdated
Show resolved
Hide resolved
jamiehumphries
previously requested changes
Jan 23, 2024
HerPublicWebsite/Views/Partials/LocalAuthorityMessages/Pending/Default.cshtml
Outdated
Show resolved
Hide resolved
…h statement to match new directory structure.
Joe-Edwards
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://beisdigital.atlassian.net/browse/PC-550