adding new versions of the ipi pipeline, and associated tasks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the README to cover the docs on the newer version. Ready for review. |
| - name: wait-for-api | ||
| params: | ||
| - name: SCRIPT | ||
| value: while ! curl https://api.openshift-demo.cor00005-2.cna.ukcloud.uk:6443 |
There was a problem hiding this comment.
Should this hard-coded url be a parameter instead?
There was a problem hiding this comment.
Probably a parameter - good point
| - name: wait-for-operator | ||
| image: $(params.IMAGE) | ||
| script: | | ||
| export KUBECONFIG=$(workspaces.persistent.path)/auth/kubeconfig |
There was a problem hiding this comment.
Could we use the env parameter to define this instead of having it in the script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit rough - but it deploys a working cluster given the appropriate inputs and pre-reqs.
To-do: Usage guidance and list of pre-requisites.