Ensure mode_appt_constraints shift even under naive policy #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbhallett
reviewed
Sep 12, 2023
tbhallett
approved these changes
Sep 12, 2023
tbhallett
deleted the
molaro/ensure-mode-shift-even-under-naive-policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we assumed a mode_appt_constraints = 2 under a "naive" policy from 2010, and switched the policy in 2023. If in 2023 we wanted to continue with a "naive" policy, there was therefore no need to schedule a policy change in 2023.
However we now assume a mode_appt_constraints = 1 until 2023; this means that the policy change (which also takes care of switching the mode) should be scheduled even in the case of the "naive" policy, to ensure that the mode_appt_constraints shift takes when evaluating a "naive" policy too.
We have fixed this + changed the name of the policy-change function to more accurately reflect that it also takes care of changing mode of appt delivery.