Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calibrations stats for COPD #1087

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

tbhallett
Copy link
Collaborator

@tbhallett tbhallett commented Aug 31, 2023

Fixes #1085

@mnjowe mnjowe self-assigned this Sep 1, 2023
@tbhallett
Copy link
Collaborator Author

Hi @mnjowe

Could I just double-check that the changes to the calibration figures that this code change brings in, are already include in the write-up document?

If so, please do 'Approve' the review of this and then I'll merge it.

@tbhallett tbhallett requested a review from mnjowe February 6, 2024 22:05
@mnjowe
Copy link
Collaborator

mnjowe commented Feb 7, 2024

@tbhallett I'm re-running this file now. I will confirm the results after it has finished. Thanks

@andrew-phillips-1
Copy link
Collaborator

@tbhallett Would you like me to review the updated graphs to check I am happy with them ? Happy to do so if you show me the link to them @mnjowe

@mnjowe
Copy link
Collaborator

mnjowe commented Feb 7, 2024

@andrew-phillips-1, Yes I would be happy if you take a look at them. I will share you the link once I'm done running the simulation. Thanks

…alibrations. Logging COPD logs in copd calibration
@mnjowe
Copy link
Collaborator

mnjowe commented Feb 7, 2024

@tbhallett and @andrew-phillips-1 . I've made some minor changes to both the calibration and analyses file - see the commit above. I'm also attaching the COPD writeup with updated plots and have also added the modal outputs values in the modal outputs table. The plots haven't changed that much.

@tbhallett hope when we agree on the updated plots you will also update the write-up on tlo website. Thanks
Copd.docx

@mnjowe
Copy link
Collaborator

mnjowe commented Feb 7, 2024

Just seeing that for relative rate of death according to COPD we are using 2023 data(Mannino et al 2003 ) . Correcting calibration plot on relative deaths now

@mnjowe
Copy link
Collaborator

mnjowe commented Feb 7, 2024

@andrew-phillips-1 and @tbhallett . Kindly find attached, the updated write-up. Thanks
Copd.docx

@andrew-phillips-1
Copy link
Collaborator

Thanks @mnjowe (and @tbhallett) These generally look good. For the last two graphs, have the results changed much from the ones we were looking at when this was being developed ? If so, I can't recall our discussions on how we reconciled ourselves to the large differences between data and model. The difference goes one way in the second last graph and the other way in the last graph. (Incidentally, if the last graph is "relative rate" then the units should not include the "per 100 person years". It would be helpful if the footnote for each graph mentions the reference for the data source (if you still have this).

@mnjowe
Copy link
Collaborator

mnjowe commented Feb 8, 2024

Hi @andrew-phillips-1 . Thanks for your feedback on this. These plots are almost the same with the last plots when COPD was being developed. For those two last calibration plots, we agreed to just to include them in the write-up BUT trust the modal GBD plots on deaths if we're looking at deaths calibration (@tbhallett correct me if I'm missing something).

@andrew-phillips-1
Copy link
Collaborator

Ah yes @mnjowe thanks. I now recall that discussion. That seems fine. For the last graph since it is a relative rate perhaps we could plot on a log scale ?

@tbhallett
Copy link
Collaborator Author

I'm adding the docx to this PR

Copy link
Collaborator

@mnjowe mnjowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to the outputs. I think we can now merge this

@tbhallett tbhallett merged commit 7c20a2e into master Feb 8, 2024
2 checks passed
@tbhallett tbhallett deleted the hallett/update-copd-calibration-stats branch February 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

COPD relative rate of death calibration
3 participants