Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citation file #1074

Merged
merged 12 commits into from
Aug 30, 2023
Merged

Add citation file #1074

merged 12 commits into from
Aug 30, 2023

Conversation

tbhallett
Copy link
Collaborator

@tbhallett tbhallett commented Aug 19, 2023

@tbhallett
Copy link
Collaborator Author

tbhallett commented Aug 19, 2023

@joehcollins -- this is the citation file that I'm adding the repo. Please could you review and approve the PR? Once we have this is, we can make the repo public.

@joehcollins
Copy link
Collaborator

Sorry tim just saw this - having a look now!

@joehcollins
Copy link
Collaborator

Looks like checks are failing as "lists of files in version control and sdist do not match!"

@tbhallett
Copy link
Collaborator Author

Looks like checks are failing as "lists of files in version control and sdist do not match!"

I don't really know what I'm doing here. But, I've made another change to the MANIFEST.in file. If it doesn't work, then I'll ask for some help.

Copy link
Collaborator

@matt-graham matt-graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than a few small bits. @tbhallett if you are happy for me to do so, I'll enable the Zenodo GitHub integration for the repository once it's been made public but before we create the 1.0.0 release as then we'll automatically get a DOI created for each new release (and also have the source code separately archived on Zenodo which is good from a long term availability perspective).

Unfortunately there is a bit of a chicken and egg situation with Zenodo / GitHub that we can't get a DOI until we create a release if using the automatic integration, so we can't include the DOI in the citation file until after we have tagged the release but that is a very minor issue!

CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
@tbhallett
Copy link
Collaborator Author

Looks good other than a few small bits. @tbhallett if you are happy for me to do so, I'll enable the Zenodo GitHub integration for the repository once it's been made public but before we create the 1.0.0 release as then we'll automatically get a DOI created for each new release (and also have the source code separately archived on Zenodo which is good from a long term availability perspective).

Unfortunately there is a bit of a chicken and egg situation with Zenodo / GitHub that we can't get a DOI until we create a release if using the automatic integration, so we can't include the DOI in the citation file until after we have tagged the release but that is a very minor issue!

Thanks. So, this is the order of business (to check I understand)

  1. I'll finish this PR
  2. You review and merge it when you're happy it.
  3. I'll make it public
  4. You enable the integration with Zenodo
  5. ...... WAIT WHILE WE FINALISE THE LAST PRs ......
  6. Make the release version 1?

@matt-graham
Copy link
Collaborator

Thanks. So, this is the order of business (to check I understand)

  1. I'll finish this PR
  2. You review and merge it when you're happy it.
  3. I'll make it public
  4. You enable the integration with Zenodo
  5. ...... WAIT WHILE WE FINALISE THE LAST PRs ......
  6. Make the release version 1?

Yep that sounds all correct to me

Copy link
Collaborator

@matt-graham matt-graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor comments, but other than potential issue with MANIFEST which might cause check to fail, none of these are vital.

LICENSE.txt Outdated Show resolved Hide resolved
MANIFEST.in Show resolved Hide resolved
setup.py Show resolved Hide resolved
tbhallett and others added 3 commits August 30, 2023 12:27
Co-authored-by: Matt Graham <[email protected]>
Co-authored-by: Matt Graham <[email protected]>
Co-authored-by: Matt Graham <[email protected]>
@tbhallett tbhallett merged commit aace4d1 into master Aug 30, 2023
55 checks passed
@tbhallett tbhallett deleted the hallett/add-citation-file branch August 30, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants