Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from swcarpentry:main #44

Closed
wants to merge 8 commits into from
Closed

[pull] main from swcarpentry:main #44

wants to merge 8 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jul 2, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

ndporter and others added 7 commits May 16, 2024 09:08
Replace `size` with `linewidth` for `geom_smooth()` example. Using `size` for lines was deprecated per this error message:

> > ggplot(data=gapminder,
> +        mapping=aes(x=gdpPercap,
> +                    y=lifeExp)) +
> +   geom_point(alpha=0.5) +
> +   scale_x_log10() +
> +   geom_smooth(method='lm', size=1.5)
> `geom_smooth()` using formula = 'y ~ x'
> Warning message:
> Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0.
> ℹ Please use `linewidth` instead.
> This warning is displayed once every 8 hours.
> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated. 

Change throughout the lesson and additionally:
1. Adjust language in explanations to match
2. Add hint to challenge clarifying size is point equivalent of linewidth.
3. Add some additional explanation of difference between aesthetics with vs without mappings.
Replace size with linewidth for geom_smooth()
Update Workflows to Version 0.16.5
Copy link

github-actions bot commented Jul 2, 2024

⚠️ WARNING ⚠️

This pull request contains a mix of workflow files and regular files. This could be malicious. No preview will be created.

regular files:

  • episodes/08-plot-ggplot2.Rmd
  • renv/profiles/lesson-requirements/renv.lock

workflow files:

  • .github/workflows/README.md
  • .github/workflows/sandpaper-version.txt

@pull pull bot added ⤵️ pull merge-conflict Resolve conflicts manually labels Jul 2, 2024
@milanmlft milanmlft closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants