Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub's Safe-Settings app to manage policy as code #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paddyroddy
Copy link
Member

This is copying the work across in the @UCL-MIRSG organisation here UCL-MIRSG/.github#141 relating to the deployment of the https://github.com/github/safe-settings app. I recently gave a brief overview of this in the DevOps Hour slides. I have created an app with the appropriate permissions, which will need to be installed organisation wide once this PR is merged.

Safe-Settings has a lot of possible options, so I've gone for as little inoffensive ones as possible. These are currently:

@paddyroddy paddyroddy added enhancement New feature or request safe-settings Related to github/safe-settings deployment renovate Related to Renovate config labels Jan 6, 2025
@paddyroddy paddyroddy self-assigned this Jan 6, 2025
@@ -0,0 +1,19 @@
# https://github.com/github/safe-settings/blob/main-enterprise/docs/sample-settings/suborg.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The downside of the app is things are mutually exclusive. If we are to enable this, it would disable any current rulesets. I've left it here for demonstration purposes.

@paddyroddy
Copy link
Member Author

Failing because the app isn't currently installed

@paddyroddy paddyroddy requested a review from samcunliffe January 6, 2025 16:39
@samcunliffe samcunliffe changed the title Add Safe-Settings app to manage policy as code Add GitHub's Safe-Settings app to manage policy as code Jan 7, 2025
Copy link
Collaborator

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking temporarily until we've resolved the discussion over in @UCL-ARC...

@samcunliffe samcunliffe requested a review from jonc125 January 7, 2025 09:34
---
repository:
allow_auto_merge: true
allow_update_branch: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we switch this to false and block all pushes to all branches?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something to discuss in the meeting I proposed. These are not meant to be the be-all and end-all settings.

safe-settings/deployment.yaml Show resolved Hide resolved
safe-settings/README.md Show resolved Hide resolved
@paddyroddy paddyroddy mentioned this pull request Jan 7, 2025
@paddyroddy
Copy link
Member Author

Blocking temporarily until we've resolved the discussion over in @UCL-ARC...

Do we have to? This could be used as another positive use-case alongside @UCL-MIRSG. It is very possible the @UCL-ARC one is never merged.

@jonc125
Copy link
Collaborator

jonc125 commented Jan 7, 2025

RC teams are still actively using this org, more so than UCL-ARC in some ways!

@paddyroddy
Copy link
Member Author

RC teams are still actively using this org, more so than UCL-ARC in some ways!

Which is exactly what @samcunliffe is trying to prevent...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request renovate Related to Renovate config safe-settings Related to github/safe-settings deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants