Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Simulation Interface Draft Stubs #49

Merged
merged 24 commits into from
Dec 3, 2023

Conversation

colinli02
Copy link
Contributor

Description

Verification

  • [ ]

Resources

@colinli02
Copy link
Contributor Author

@hhenry01

Hey Henry, I have:

  • resolved merge conflicts
  • removed 'auto'
  • removed RCLCPP_INFO() logging from terminal

Should be ready for merge

@hhenry01
Copy link
Member

hhenry01 commented Nov 1, 2023

Make to follow ROS style guidelines, in particular for variables: http://wiki.ros.org/CppStyleGuide#Variables.

@hhenry01
Copy link
Member

hhenry01 commented Nov 1, 2023

For every .cpp and .h file you've touched, open the command palette (ctrl+shift+p) and run format document. This should run automatically on manual save, but I'm assuming you have auto-save on.

@colinli02
Copy link
Contributor Author

colinli02 commented Nov 8, 2023

For every .cpp and .h file you've touched, open the command palette (ctrl+shift+p) and run format document. This should run automatically on manual save, but I'm assuming you have auto-save on.

I have auto-save off on vscode, I normally just click ctrl + s after a couple lines out of muscle memory, is the formatting not working / not expected what it should look like?

I've ran the formatter under command palette either way, with clangd format

@hhenry01
Copy link
Member

hhenry01 commented Nov 8, 2023

For every .cpp and .h file you've touched, open the command palette (ctrl+shift+p) and run format document. This should run automatically on manual save, but I'm assuming you have auto-save on.

I have auto-save off on vscode, I normally just click ctrl + s after a couple lines out of muscle memory, is the formatting not working / not expected what it should look like?

I've ran the formatter under command palette either way, with clangd format

Formatting was broken and I didn't catch it because of one of my user settings. I'll fix it soon. Thanks for catching this.

Edit: Fixed in: UBCSailbot/sailbot_workspace#202

@hhenry01
Copy link
Member

hhenry01 commented Nov 9, 2023

Make to follow ROS style guidelines, in particular for variables: http://wiki.ros.org/CppStyleGuide#Variables.

Take another look at this. Particularly for variable names.

Copy link
Member

@hhenry01 hhenry01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be misunderstanding for how the CanSimIntf plugs in to the overall software flow alongside the regular CanTransceiverIntf. We'll need to talk about this more in depth.

@colinli02
Copy link
Contributor Author

Make to follow ROS style guidelines, in particular for variables: http://wiki.ros.org/CppStyleGuide#Variables.

Take another look at this. Particularly for variable names.

I've changed all variables and member variable names to underscored and lower case

@colinli02 colinli02 merged commit 092d0a6 into main Dec 3, 2023
12 checks passed
@colinli02 colinli02 deleted the user/colinli02/16-CAN-Sim-Interface-Stubs branch December 3, 2023 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAN Sim Interface Stubs
2 participants