[BE] 모임 삭제 #85
Merged
[BE] 모임 삭제 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
320Hwany
reviewed
May 2, 2024
Comment on lines
25
to
28
| JoinedMoimJpaEntity joinedMoimJpaEntity = JoinedMoimJpaEntity.builder() | ||
| .moimId(moimId) | ||
| .memberId(memberId) | ||
| .build(); |
320Hwany
reviewed
May 2, 2024
Comment on lines
+29
to
+41
|
|
||
| private final MoimAppender moimAppender; | ||
| private final FileUploader fileUploader; | ||
| private final MoimFinder moimFinder; | ||
| private final MoimUpdater moimUpdater; | ||
| private final MoimRemover moimRemover; | ||
| private final JoinedMoimAppender joinedMoimAppender; | ||
| private final MeetingFinder meetingFinder; | ||
| private final JoinedMeetingRemover joinedMeetingRemover; | ||
| private final TodoRemover todoRemover; | ||
| private final JoinedMoimRemover joinedMoimRemover; | ||
| private final ScheduleRemover scheduleRemover; | ||
|
|
There was a problem hiding this comment.
이거 implement에서 좀 더 묶고 Service에 넘겨도 좋을 것 같습니당
Anak-2
approved these changes
May 2, 2024
|
|
||
| @Transactional | ||
| public void createJoinedMoim(final long memberId, final long moimId) { | ||
| moimFinder.getById(moimId); |
There was a problem hiding this comment.
validate 로 의도를 나타내는 함수 하나 만들면 더 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
💬리뷰 요구사항(선택)