Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatpak build #189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Totto16
Copy link

@Totto16 Totto16 commented Dec 4, 2023

This provides a flatpak manifest to build aegisub as flatpak application

  • it adds a CI that builds it
  • it also adds DependencyControl (I find it helpful, to include that in a flatpak build, but ofc it could be changed)
  • it fixes some names, that require a certain schema on flatpak (icons, app_name etc.)
  • this builds the dependencies like boost, wxWidgets beforehand with their own build system, mainly due to local development concerns, but also to be sure, that no bug occurs in the meson conversion of these dependencies
  • it uses
    • lua 5.1
    • wxWidgets 3.2.3
    • boost 1.83.0
    • libass 0.17.1 (this builds from the original repo, but since this manifest is a little bit older, where the meson port didn't have these adjustments, it could be changed to that

org.aegisub.Aegisub.yml Outdated Show resolved Hide resolved
org.aegisub.Aegisub.yml Outdated Show resolved Hide resolved
@zefr0x
Copy link

zefr0x commented Dec 11, 2023

You might want to look at Aegisub#336.

I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

@Totto16
Copy link
Author

Totto16 commented Dec 11, 2023

You might want to look at Aegisub#336.

I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Your package seems much more sophisticated, but since the main work for Aegisub/Aegisub is done here, and with meson as build system, with the version of the libraries, that are used here, and this is eventually merged into that repo, it would be better to build on this repo, maybe we could merge the manifests in some way 🤔

@zefr0x
Copy link

zefr0x commented Dec 11, 2023

You might want to look at Aegisub#336.
I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Your package seems much more sophisticated, but since the main work for Aegisub/Aegisub is done here, and with meson as build system, with the version of the libraries, that are used here, and this is eventually merged into that repo, it would be better to build on this repo, maybe we could merge the manifests in some way 🤔

I don't think that Flathub would accept a fork with no official stable release.

Any way it's easy to use the new build system, noting huge need to be changed (I even have it commented in the manifest).

If Flathub don't have any problems I will relay on TypesettingTools/Aegisub. I will ask them when I open a pull request.

@Totto16
Copy link
Author

Totto16 commented Dec 11, 2023

You might want to look at Aegisub#336.
I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Your package seems much more sophisticated, but since the main work for Aegisub/Aegisub is done here, and with meson as build system, with the version of the libraries, that are used here, and this is eventually merged into that repo, it would be better to build on this repo, maybe we could merge the manifests in some way 🤔

I don't think that Flathub would accept a fork with no official stable release.

Any way it's easy to use the new build system, noting huge need to be changed (I even have it commented in the manifest).

If Flathub don't have any problems I will relay on TypesettingTools/Aegisub. I will ask them when I open a pull request.

The only main difference between the meson and the autotools version is the flatpak specific things, like .desktop file with name (not aegisub but "org.aegisub.Aegisub") and the icons names, the rest is nearly the same, since I also used the native build systems for the dependencies, but not that many specific options etc. I also added Dependency control, which could be controversial. IMO it's much more concise, to modfiy a few lines of the build system than patching the original code up, to rename these etc. Meson is better integrated than autotools in the flatpak-builder etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants