Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriptions through EventSub #415

Merged
merged 14 commits into from
Sep 1, 2024
Merged

subscriptions through EventSub #415

merged 14 commits into from
Sep 1, 2024

Conversation

Felk
Copy link
Member

@Felk Felk commented Jun 29, 2024

No description provided.

@Felk Felk force-pushed the twitch_eventsub_subsriptions branch from 022484b to 60a95a0 Compare July 30, 2024 20:16
@Felk Felk force-pushed the twitch_eventsub_subsriptions branch from 60a95a0 to 9d35fb5 Compare August 12, 2024 13:58
@Felk Felk marked this pull request as ready for review August 12, 2024 13:58
@Felk
Copy link
Member Author

Felk commented Aug 12, 2024 •
edited
Loading

unit tests and some local testing using the twitch CLI look promising. This is ready for some real TPP-style testing in production 💪

@Felk Felk force-pushed the twitch_eventsub_subsriptions branch from 9d35fb5 to e6d56eb Compare August 12, 2024 14:00
@Felk Felk mentioned this pull request Aug 12, 2024
Closed
@Felk Felk force-pushed the twitch_eventsub_subsriptions branch from e6d56eb to aee2227 Compare August 15, 2024 21:56
@Felk Felk force-pushed the twitch_eventsub_subsriptions branch from 96d4777 to eac931a Compare August 22, 2024 18:18
@Felk
Copy link
Member Author

Felk commented Aug 22, 2024

Seems to work now: branch is live on stream, m4 gifted a sub and both recipients got their tokens. Let's let stream run off of this branch for some more time, but this is probably safe to merge now

@Felk
Copy link
Member Author

Felk commented Aug 23, 2024 •
edited
Loading

Another issue occurred:

ArgumentNullException
   at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.Select[TSource,TResult](IEnumerable`1 source, Func`2 selector)
   at TPP.Core.Chat.TwitchEventSubChat.ChannelSubscriptionMessageReceived(ChannelSubscriptionMessage channelSubscriptionMessage) in /home/runner/work/tpp-core/tpp-core/TPP.Core/Chat/TwitchEventSubChat.cs:line 493
   at TPP.Core.Chat.TwitchEventSubChat.<>c__DisplayClass20_0.<<-ctor>b__3>d.MoveNext() in /home/runner/work/tpp-core/tpp-core/TPP.Core/Chat/TwitchEventSubChat.cs:line 95
--- End of stack trace from previous location ---
   at TPP.Core.EventUtils.TaskToVoidSafely(ILogger logger, Func`1 action) in /home/runner/work/tpp-core/tpp-core/TPP.Core/EventUtils.cs:line 22

https://discord.com/channels/333356453928894466/579758730418192399/1276537747070255124

@Felk Felk merged commit 8da20cd into master Sep 1, 2024
8 checks passed
@Felk Felk deleted the twitch_eventsub_subsriptions branch September 1, 2024 14:30
@Felk Felk mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Felk