IrcParser: make public and speed up by another <=15% #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #217
Description
We can now make
IrcParser
public and it will do the right thing (tm) when utilized from user code.To be honest, it is pretty meaningless to continue improving parsing performance since
TwitchLib
impl. is now faster than popular alternatives in Java, Rust and Go (some of them kind of shoot themselves in the foot though). But hey, neuron activation.Numbers
(before version supposedly roll-forwarded to a newer compiler version too so runtime perf. differences should not be significant)
Before:
After: