-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extracted tag parsing logic, changes for NET6/NET7 #238
Conversation
…eplaced by `Color Color` property), extracted tag parsing logic into a separate class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite get why you changed it first just to revert it for a nicer gitdiff?
I changed it to |
@AoshiW Btw, if you want to clean up git history, you can "Undo" commits in VS Code + GitLens or just reset to a, let's say, previous commit, then commit again in the desired form, and then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just seeking clarity on the Color possible issue
lgtm |
Changes:
Color Color
properties (or replaced bystring HexColor
property) and created interface for easier parsing of HexColor on user-sidestring TmiSendTs
properties withDateTimeOffset TmiSend