Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extracted tag parsing logic, changes for NET6/NET7 #238

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

AoshiW
Copy link

@AoshiW AoshiW commented Jul 5, 2023

Changes:

  • (performance) changes for NET6/NET7/netstandard2.1
  • deleted all Color Color properties (or replaced by string HexColor property) and created interface for easier parsing of HexColor on user-side
  • replace all string TmiSendTs properties with DateTimeOffset TmiSend
  • extracted tag parsing logic into a separate class

Copy link
Member

@Syzuna Syzuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get why you changed it first just to revert it for a nicer gitdiff?

@AoshiW
Copy link
Author

AoshiW commented Jul 8, 2023

I changed it to tag.Value automatically without thinking but then I realized that it was an unnecessary change (and maybe even unwanted) so I changed it back to
(so please use Squash and merge so no one sees my useless commits)

@neon-sunset
Copy link

neon-sunset commented Jul 9, 2023

@AoshiW Btw, if you want to clean up git history, you can "Undo" commits in VS Code + GitLens or just reset to a, let's say, previous commit, then commit again in the desired form, and then git push -f - this will override commit history, making it look as if the previous commits never happened. People do this in popular and/or big repositories a lot.

Copy link
Member

@swiftyspiffy swiftyspiffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just seeking clarity on the Color possible issue

@AoshiW AoshiW requested a review from Syzuna July 31, 2023 16:13
@swiftyspiffy
Copy link
Member

lgtm

@swiftyspiffy swiftyspiffy merged commit 989bc8d into TwitchLib:dev Aug 4, 2023
1 check passed
@AoshiW AoshiW deleted the modern-NET branch August 4, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants