Remove resume_from

[penelopeysm]

First step towards TuringLang/Turing.jl#2171.

This is another breaking change.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.09%. Comparing base (003ff2f) to head (a0e6f32).

Files with missing lines	Patch %	Lines
src/sampler.jl	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   86.13%   86.09%   -0.04%     
==========================================
  Files          36       36              
  Lines        4336     4338       +2     
==========================================
  Hits         3735     3735              
- Misses        601      603       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coveralls]

Pull Request Test Coverage Report for Build 12582651121

Details

• 8 of 9 (88.89%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.1%) to 86.025%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/sampler.jl	1	2	50.0%

Files with Coverage Reduction	New Missed Lines	%
src/sampler.jl	1	91.23%

Totals
Change from base Build 12436748831:	-0.1%
Covered Lines:	3718
Relevant Lines:	4322

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 12672147706

Details

• 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
• 30 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.04%) to 86.179%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/sampler.jl	1	2	50.0%

Files with Coverage Reduction	New Missed Lines	%
src/sampler.jl	1	92.75%
src/varinfo.jl	3	84.92%
src/model.jl	5	77.39%
src/threadsafe.jl	21	46.61%

Totals
Change from base Build 12657521724:	-0.04%
Covered Lines:	3735
Relevant Lines:	4334

---

💛 - Coveralls

[penelopeysm]

I don't actually how how to test this inside DynamicPPL, because save_state only works when called with the implementation of sample() in Turing.jl.

I suspect the whole implementation of bundle_samples (https://github.com/TuringLang/Turing.jl/blob/0c3d3d00705cd5e58623f96cc71a1999e0896809/src/mcmc/Inference.jl#L465-L525) needs to be upstreamed into DynamicPPL

[penelopeysm]

Going to mark as draft again because I need to have a think about the right sequence of events here. In particular I'm wondering if we need to sort out the AbstractMCMC interface first