Small improvements to probability docs #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11134139385Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 11147721660Details
💛 - Coveralls |
penelopeysm
force-pushed
the
py/docs
branch
2 times, most recently
from
dc65293
to
359bc31
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 76.62% 77.31% +0.69%
==========================================
Files 29 29
Lines 3589 3589
==========================================
+ Hits 2750 2775 +25
+ Misses 839 814 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@torfjelde, just looking for a second opinion on moving this to the docs repo 🙂 if you agree I can sort that out |
|
LGTM @penelopeysm !:) |
torfjelde
approved these changes
Oct 2, 2024
|
Brilliant, I'll edit this PR to remove this page and move it over there :) thanks! |
penelopeysm
added a commit
to TuringLang/docs
that referenced
this pull request
Oct 2, 2024
See TuringLang/DynamicPPL.jl#675 Some minor changes made, namely importing Turing over importing DynamicPPL since that's what most people reading this will be doing.
penelopeysm
added a commit
to TuringLang/docs
that referenced
this pull request
Oct 2, 2024
See TuringLang/DynamicPPL.jl#675 Some minor changes made, namely importing Turing over importing DynamicPPL since that's what most people reading this will be doing.
penelopeysm
added a commit
to TuringLang/docs
that referenced
this pull request
Oct 2, 2024
See TuringLang/DynamicPPL.jl#675 Some minor changes made, namely importing Turing over importing DynamicPPL since that's what most people reading this will be doing.
yebai
pushed a commit
to TuringLang/docs
that referenced
this pull request
Oct 3, 2024
See TuringLang/DynamicPPL.jl#675 Some minor changes made, namely importing Turing over importing DynamicPPL since that's what most people reading this will be doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few small improvements to the docs.
Preview: https://turinglang.org/DynamicPPL.jl/previews/PR675/tutorials/prob-interface/
Actually, in addition to these changes, I'd also love to see this be moved to the docs repository instead. I think we should reserve
turinglang.org/${PACKAGE}for API documentation, and anything that talks about how to use it should be on the main docs page, otherwise it's rather less discoverable.