-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subset
and merge
for VarInfo
#543
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this is based on #542 (because I wanted to test the Gibbs PR with this) |
torfjelde
force-pushed
the
torfjelde/varinfo-ops
branch
from
October 8, 2023 23:18
bde00d0
to
ac91cfc
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
torfjelde
force-pushed
the
torfjelde/varinfo-ops
branch
from
October 8, 2023 23:21
ac91cfc
to
743c8b6
Compare
torfjelde
force-pushed
the
torfjelde/varinfo-ops
branch
from
October 9, 2023 09:36
743c8b6
to
1d8d507
Compare
Comment on lines
+452
to
+455
push!( | ||
vals.args, | ||
:(merge_metadata(metadata_left.$sym, metadata_right.$sym)) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
push!( | |
vals.args, | |
:(merge_metadata(metadata_left.$sym, metadata_right.$sym)) | |
) | |
push!(vals.args, :(merge_metadata(metadata_left.$sym, metadata_right.$sym))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement a
Gibbs
sampler based oncondition
a la TuringLang/Turing.jl#2099 we need two missing operations forVarInfo
:subset(varinfo, varnames)
: creates aVarInfo
fromvarinfo
based only onvarnames
.merge(varinfo_left, varinfo_right)
: attempts to merge two instances ofVarInfo
into a singleVarInfo
. These can include both shared and not-shared variables.Here's an example:
Note that none of these are, at the moment, implemented for
SimpleVarInfo
. This is both because (1) we don't need it yet, and (2) this will support a much smaller set of combinations.