Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for linking #513

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Bugfix for linking #513

merged 7 commits into from
Aug 7, 2023

Conversation

torfjelde
Copy link
Member

Fixes part of the issues discussed in #504.

It turns out we forgot to add the test/linking.jl to test/runtests.jl so we haven't been testing the linking properly 🤦 This is also fixed here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Pull Request Test Coverage Report for Build 5770940094

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 76.221%

Totals Coverage Status
Change from base Build 5765768895: 0.7%
Covered Lines: 2106
Relevant Lines: 2763

💛 - Coveralls

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.72% 🎉

Comparison is base (aa13dcf) 75.49% compared to head (3528200) 76.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   75.49%   76.22%   +0.72%     
==========================================
  Files          23       23              
  Lines        2763     2763              
==========================================
+ Hits         2086     2106      +20     
+ Misses        677      657      -20     
Files Changed Coverage Δ
src/varinfo.jl 81.10% <100.00%> (+3.29%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torfjelde
Copy link
Member Author

torfjelde commented Aug 5, 2023

@yebai @devmotion could one of you have a look at this?:) Should be a fairly quick merge I believe.

EDIT: Though I realize it's a weekend, so np if unavailable!

test/linking.jl Outdated Show resolved Hide resolved
test/linking.jl Outdated Show resolved Hide resolved
test/linking.jl Outdated Show resolved Hide resolved
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some minor comments. Feel free to merge once they are addressed 🙂

@torfjelde torfjelde added this pull request to the merge queue Aug 7, 2023
Merged via the queue into master with commit 1ebe8bc Aug 7, 2023
12 of 13 checks passed
@torfjelde torfjelde deleted the torfjelde/support-fixes branch August 7, 2023 05:37
@torfjelde torfjelde mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants