-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for linking #513
Bugfix for linking #513
Conversation
Pull Request Test Coverage Report for Build 5770940094
💛 - Coveralls |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
==========================================
+ Coverage 75.49% 76.22% +0.72%
==========================================
Files 23 23
Lines 2763 2763
==========================================
+ Hits 2086 2106 +20
+ Misses 677 657 -20
☔ View full report in Codecov by Sentry. |
@yebai @devmotion could one of you have a look at this?:) Should be a fairly quick merge I believe. EDIT: Though I realize it's a weekend, so np if unavailable! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only some minor comments. Feel free to merge once they are addressed 🙂
Co-authored-by: David Widmann <[email protected]>
Fixes part of the issues discussed in #504.
It turns out we forgot to add the
test/linking.jl
totest/runtests.jl
so we haven't been testing the linking properly 🤦 This is also fixed here.