-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #511 #512
Fix for #511 #512
Conversation
replace_returns in return statements
missing and nothing
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
==========================================
+ Coverage 75.47% 75.49% +0.02%
==========================================
Files 23 23
Lines 2764 2763 -1
==========================================
Hits 2086 2086
+ Misses 678 677 -1
☔ View full report in Codecov by Sentry. |
Feel free to merge this as soon as someone has approved and the tests have passed 👍 |
Pull Request Test Coverage Report for Build 5764647699
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not completely familiar with the previous implementation but looks good to me.
Because we add a
return
to the last statement in the model body before replacing returns + we don't recursively callreplace_returns!
on the args to thereturn
statement, we run into issues when the last statement in the body itself containsreturn
(as in #511).This PR addresses this issue.