Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary namespace qualifications #508

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Remove unnecessary namespace qualifications #508

merged 2 commits into from
Jul 30, 2023

Conversation

devmotion
Copy link
Member

It seems there are quite a few examples of unnecessary namespace qualifications in DynamicPPL. This PR fixes a few of them.

src/prob_macro.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2023

Pull Request Test Coverage Report for Build 5706550847

  • 9 of 19 (47.37%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.47%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model_utils.jl 0 2 0.0%
src/simple_varinfo.jl 0 2 0.0%
src/test_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 5695265951: 0.0%
Covered Lines: 2086
Relevant Lines: 2764

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 47.36% and no project coverage change.

Comparison is base (2a1019b) 75.47% compared to head (0deb12e) 75.47%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   75.47%   75.47%           
=======================================
  Files          23       23           
  Lines        2764     2764           
=======================================
  Hits         2086     2086           
  Misses        678      678           
Files Changed Coverage Δ
src/model_utils.jl 19.64% <0.00%> (ø)
src/simple_varinfo.jl 67.77% <0.00%> (ø)
src/test_utils.jl 84.65% <0.00%> (ø)
src/model.jl 88.34% <100.00%> (ø)
src/prob_macro.jl 84.67% <100.00%> (ø)
src/submodel_macro.jl 94.28% <100.00%> (ø)
src/transforming.jl 100.00% <100.00%> (ø)
src/utils.jl 76.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dopey:)

@yebai yebai enabled auto-merge July 30, 2023 15:39
@yebai yebai added this pull request to the merge queue Jul 30, 2023
Merged via the queue into master with commit 5dd7c53 Jul 30, 2023
11 of 13 checks passed
@yebai yebai deleted the dw/clean branch July 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants