Fix MethodAmbiguity errors #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
merged commit b5e152c
into
torfjelde/default-impls-for-filldist-and-array-dist
15 checks passed
yebai
pushed a commit
that referenced
this pull request
Apr 17, 2024
* added default impls for `filldist` and `arraydist` * Apply suggestions from code review Co-authored-by: David Widmann <[email protected]> * Update filldist.jl (#265) --------- Co-authored-by: David Widmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly this fixes the method ambiguity issues in #264. At least it shows that there is an inconsistency in the definition of
filldistcurrently - most methods are defined forInts but one is defined forIntegers.