Expose API for Turing integration #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 95.86% 96.09% +0.23%
==========================================
Files 8 8
Lines 411 410 -1
==========================================
Hits 394 394
+ Misses 17 16 -1
☔ View full report in Codecov by Sentry. |
yebai
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Thanks @FredericWantiez -- it looks nice overall. I left a few minor comments below.
ext/AdvancedPSLibtaskExt.jl
Outdated
| @@ -134,10 +131,10 @@ function AbstractMCMC.step( | |||
| # Create reference trajectory. | |||
| AdvancedPS.forkr(copy(state.trajectory)) | |||
| else | |||
| println(model) | |||
ext/AdvancedPSLibtaskExt.jl
Outdated
| trace = AdvancedPS.Trace(LibtaskModel(deepcopy(model), trng), trng) | ||
| addreference!(gen_model.ctask.task, trace) # Do we need it here ? | ||
| trace = AdvancedPS.Trace(deepcopy(model), trng) | ||
| AdvancedPS.addreference!(trace.model.ctask.task, trace) # Do we need it here ? |
There was a problem hiding this comment.
Suggested change
| AdvancedPS.addreference!(trace.model.ctask.task, trace) # Do we need it here ? | |
| AdvancedPS.addreference!(trace.model.ctask.task, trace) # TODO: Do we need it here ? |
| gen_model = LibtaskModel(deepcopy(model), trng) | ||
| trace = AdvancedPS.Trace(LibtaskModel(deepcopy(model), trng), trng) | ||
| addreference!(gen_model.ctask.task, trace) # Do we need it here ? | ||
| trace = AdvancedPS.Trace(deepcopy(model), trng) |
There was a problem hiding this comment.
Did we define deepcopy(::LibtaskModel)? I can't find it.
There was a problem hiding this comment.
I think model here is still the original model type: AbstractGenericModel of some sort. We wrap it inside a LibtaskModel in the Trace constructor
Pull Request Test Coverage Report for Build 6750233421
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.