Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update callback signature in docs #130

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Update callback signature in docs #130

merged 1 commit into from
Sep 27, 2023

Conversation

devmotion
Copy link
Member

Fixes #129.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d7c549f) 97.37% compared to head (687110d) 97.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files           8        8           
  Lines         305      305           
=======================================
  Hits          297      297           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for not doing this myself; added the issue during a live coding session.

@devmotion
Copy link
Member Author

No worries. I was checking the AbstractMCMC code and thought I could just fix the issue right away 🙂

@devmotion devmotion merged commit caeade2 into master Sep 27, 2023
29 of 30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the dw/docs_callback branch September 27, 2023 11:55
torfjelde added a commit that referenced this pull request Oct 24, 2023
torfjelde added a commit that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs on callback is missing state argument
2 participants