Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a structure for representative periods #273

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

abelsiqueira
Copy link
Member

Pull request details

Describe the changes made in this pull request

Create a structure for representative periods.
Move the constraints partition to the model creation.

List of related issues or pull requests

Closes #262

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9da51b2) 100.00% compared to head (d029cc0) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          230       230           
=========================================
  Hits           230       230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the readability of the code in the model. Thanks

@datejada datejada merged commit 0cb8f29 into TulipaEnergy:main Nov 18, 2023
6 checks passed
@abelsiqueira abelsiqueira deleted the 262-rp-struct branch November 20, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a structure for the representative periods and other time stuff
2 participants