Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id from CSV files and use the asset name explicitly #270

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

abelsiqueira
Copy link
Member

Pull request details

Describe the changes made in this pull request

Remove ids.
For assets, add asset name to use as key.
For flows, add from_asset, to_asset pair to use as key.
Update a few places to match the new input.

List of related issues or pull requests

Closes #269

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcc40f1) 100.00% compared to head (3fb57c9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          204       212    +8     
=========================================
+ Hits           204       212    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It was a huge change, after all. I only suggested a slight change due to my OCD, so it is approved in any case :)

src/input-tables.jl Outdated Show resolved Hide resolved
Co-authored-by: Diego Alejandro Tejada Arango <[email protected]>
@abelsiqueira
Copy link
Member Author

Thanks for the review. Change merged.

@abelsiqueira abelsiqueira merged commit 88e6e10 into TulipaEnergy:main Nov 17, 2023
@abelsiqueira abelsiqueira deleted the 269-use-labels-on-csv branch November 17, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing flow id to from, to pair in the CSV files
2 participants