-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement solution saving and exporting for refactored code #1000
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
- Coverage 95.43% 95.22% -0.22%
==========================================
Files 29 29
Lines 1140 1151 +11
==========================================
+ Hits 1088 1096 +8
- Misses 52 55 +3 ☔ View full report in Codecov by Sentry. |
src/io.jl
Outdated
@@ -320,158 +320,52 @@ end | |||
save_solution_to_file(output_folder, energy_problem) | |||
|
|||
Saves the solution from `energy_problem` in CSV files inside `output_file`. | |||
Notice that this assumes that the solution has been computed by [`save_solution!`](@ref). | |||
""" | |||
function save_solution_to_file(output_folder, energy_problem::EnergyProblem) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To differentiate more from the save_solution
function and account for future options to export to another format, I propose renaming this function as export_solution_to_csv_files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @abelsiqueira; I have left some comments. Let me know what you think.
Co-authored-by: Diego Alejandro Tejada Arango <[email protected]>
Thanks for the review! I've updated the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I don´t have extra comments.
save_solution_to_file
Related issues
Closes #115
Closes #818
Checklist
I am following the contributing guidelines
Tests are passing
Lint workflow is passing
Docs were updated and workflow is passing