Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add medoids information to the results #70

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

datejada
Copy link
Member

@datejada datejada commented Oct 11, 2024

The information on the medoids is necessary for the SpineOpt model to identify the value periods in the original data. These changes add that information to the auxiliary data structure only if the method is k-medoids. The default value in the structure is nothing.

Related issues

Closes #55

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@datejada datejada requested a review from abelsiqueira October 11, 2024 09:55
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2922f4a) to head (ff768e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          217       221    +4     
=========================================
+ Hits           217       221    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datejada datejada merged commit 1ea0fc3 into TulipaEnergy:main Oct 11, 2024
7 checks passed
@datejada datejada deleted the 55-add-info-original-period branch October 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information about the "original period" corresponding to the selected representative
2 participants