Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to @mapbox/node-pre-gyp #70

Merged
merged 8 commits into from
Aug 7, 2021
Merged

chore(deps): upgrade to @mapbox/node-pre-gyp #70

merged 8 commits into from
Aug 7, 2021

Conversation

cschanaj
Copy link
Contributor

@cschanaj cschanaj commented Jul 1, 2021

This PR upgrade the deprecated package node-pre-gyp to @mapbox/node-pre-gyp.

@mapbox/node-pre-gyp requires Node 8+ and AWS SDK will only support Node 10+ starting from November 2021. So I have bump the Node version in the CI to Node 10+ as well.

The AWS SDK for JavaScript (v2) will no longer support Node.js v8.17.0
as of November 1, 2021. To continue receiving updates to AWS services
and bug fixes please upgrade to Node.js 10.x or later

P.S. Please squash and merge if it is preferred. thanks.

@cschanaj
Copy link
Contributor Author

cschanaj commented Jul 1, 2021

This PR closes #69 and bumped the supported Node versions. @codeplea would you mind to take a look at this PR and kindly consider reviewing & merging? thanks.

@codeplea
Copy link
Member

codeplea commented Jul 1, 2021

Thanks. I will look into it when I have time. Could be a couple weeks.

@cschanaj
Copy link
Contributor Author

cschanaj commented Jul 1, 2021

thanks. please feel free to ping me anytime if any modification is needed. 😄

@rafiqlightwala
Copy link

please process this

@codeplea codeplea merged commit c456802 into TulipCharts:master Aug 7, 2021
@codeplea
Copy link
Member

codeplea commented Aug 8, 2021

Thanks! It seems to be working and binaries are building and being published for Windows at the moment.

FYI, the travis-ci is now broken. I haven't dealt with them lately, and I'm not entirely sure what it'll take to fix it.

@codeplea
Copy link
Member

codeplea commented Aug 8, 2021

Turned out to be way more work than I was hoping for, but travis-ci is now mostly working too.

@cschanaj cschanaj deleted the scoped-node-pre-gyp branch August 8, 2021 08:50
@cschanaj
Copy link
Contributor Author

cschanaj commented Aug 8, 2021

It seems that a newer GCC version is required to build tulipnode with the Node 16 headers, see #72

deman4ik pushed a commit to deman4ik/tulipnode that referenced this pull request Oct 5, 2021
sanduninduwara pushed a commit to sanduninduwara/tulipnode that referenced this pull request Apr 30, 2023
sanduninduwara pushed a commit to sanduninduwara/tulipnode that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants