Skip to content
This repository has been archived by the owner on Jul 25, 2019. It is now read-only.

Update source.md to include Casper submodule #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update source.md to include Casper submodule #121

wants to merge 1 commit into from

Conversation

djruess
Copy link

@djruess djruess commented Jul 22, 2019

Hey everyone,
This is my first pull request ever, so I'm sorry if I did something wrong but I think I followed the guidelines correctly.

Here's what I updated:

  1. So I updated the source.md to include instructions for the Casper submodule: renaming origin to upstream, and adding origin for the Casper submodule.

So when I was following the installation instructions for "Install from Source," I noticed that when I ran the command 'grunt master' to update everything, it threw some fatal errors: " 'upstream' does not appear to be a git repository," in reference to the submodule Casper. (I included all the error messages I received at the end of this.)

I thought others might have this problem when trying to update the source and thought I would add the instructions I used to simply rename origin to upstream and add origin for the Casper submodule.

  1. I also added the instructions and command "git remote -v" so people could check to make sure they had entered everything correctly.

  2. I removed the instructions and command "git checkout master && git pull upstream master" because I reasoned (A) that if they had just cloned the repository, it should be updated, and (B) if they run the command 'grunt master' - that essentially does the same thing and updates all of the repositories.

  • I could be wrong about all of this - so I'm totally open to correction and any advice :)

Thanks for all your work!

  • David Ruess

Edit: p.s. I forgot to include this. This is the fatal error message I receive if I don't have the Casper submodule repository renamed:

fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: run_command returned non-zero status for content/themes/casper
.
Warning: Command failed:
                        git submodule sync
                        git submodule update

                        if ! git diff --exit-code --quiet --ignore-submodules=untracked; then
                            echo "Working directory is not clean, do you have uncommited changes? Please commit, stash or discard changes to continue."
                            exit 1
                        fi

                        git checkout master
                        git pull upstream master
                        yarn
                        git submodule foreach "
                            git checkout master && git pull upstream master
                        "

Already on 'master'
From github.com:TryGhost/Ghost
 * branch                master     -> FETCH_HEAD
   a1ece81c5..2b20ae8f7  master     -> upstream/master
warning [email protected]: The engine "cli" appears to be invalid.
warning "@tryghost/members-auth-pages > [email protected]" has unmet peer dependency "react@^15.5.4 || ^16.0.0-0".
warning "@tryghost/members-auth-pages > [email protected]" has unmet peer dependency "react-dom@^15.5.4 || ^16.0.0-0".
warning " > [email protected]" has incorrect peer dependency "knex@>=0.6.10 <0.15.0".
Switched to branch 'master'
fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: run_command returned non-zero status for content/themes/casper
.
 Use --force to continue.

Aborted due to warnings.

@netlify
Copy link

netlify bot commented Jul 22, 2019

Deploy preview for tryghost ready!

Built with commit 771da59

https://deploy-preview-121--tryghost.netlify.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant