Removed unnecessary constructor in CallToActionNode

[kevinansfield]

no issue

• generateDecoratorNode() already handles constructor creation with property assignment based on the properties array passed to it
• fixes an inconsistency in default values between the array passed to generateDecoratorNode() and the overridden constructor
  • switched to '' in place of 'none' to match other cards, updated related usage

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/koenig-lexical/src/nodes/CallToActionNode.jsx

Oops! Something went wrong! :(

ESLint: 8.57.0

ESLint couldn't find the config "react-app" to extend from. Please check that the name of the config is correct.

The config "react-app" was referenced from the config file in "/packages/koenig-lexical/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

packages/koenig-lexical/src/components/ui/cards/CtaCard.stories.jsx

Oops! Something went wrong! :(

ESLint: 8.57.0

ESLint couldn't find the config "react-app" to extend from. Please check that the name of the config is correct.

The config "react-app" was referenced from the config file in "/packages/koenig-lexical/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

packages/kg-default-nodes/lib/nodes/call-to-action/CallToActionNode.js

Oops! Something went wrong! :(

ESLint: 8.57.0

Error: Failed to load parser '@babel/eslint-parser' declared in 'packages/kg-default-nodes/.eslintrc.js': Cannot find module '@babel/eslint-parser'
Require stack:

• /packages/kg-default-nodes/.eslintrc.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
  at Function.resolve (node:internal/modules/helpers:145:19)
  at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46)
  at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39)
  at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43)
  at _normalizeObjectConfigDataBody.next ()
  at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
  at _normalizeObjectConfigData.next ()
  at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28)
  at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

Walkthrough

The pull request removes the custom constructor from the CallToActionNode class, shifting initialization responsibilities to the default logic (via generateDecoratorNode). Additionally, test assertions for the buttonColor and buttonTextColor properties have been updated to expect empty strings ('') instead of 'none'. The CtaCard component has also been adjusted for consistency in prop handling.

Changes

File(s)	Change Summary
packages/kg-default-nodes/.../CallToActionNode.js	Removed the custom constructor and its property initialization; updated the override comment; export functions unchanged, now relying on default behavior from generateDecoratorNode.
packages/kg-default-nodes/.../call-to-action.test.js	Modified test assertions by changing the expected default values for buttonColor and buttonTextColor from 'none' to an empty string ('').
packages/koenig-lexical/src/components/ui/cards/.../CtaCard.stories.jsx	Reformatted prop handling for consistency; changed condition for wrapperStyle from checking 'none' to an empty string.
packages/koenig-lexical/src/nodes/.../CallToActionNode.jsx	Altered the decorate method to change the logic for wrapperStyle based on the truthiness of this.backgroundColor.

Possibly related PRs

• Added CallToAction Lexical Nodes #1412: The changes in the main PR, which involve the removal of the constructor in the CallToActionNode class, are directly related to the modifications in the test suite of the retrieved PR, as both address the default values for properties of the same class.
• Updated CTA card icon in card menu #1423: The changes in the main PR, which involve the removal of the constructor in the CallToActionNode class and adjustments to default property values, are directly related to the modifications in the retrieved PR that also alter the default values and properties of the same class.
• Updated CTA card cardwrapper behavior #1414: The changes in the main PR, which involve modifications to the CallToActionNode class and its default property values, are related to the adjustments made in the retrieved PR regarding the CtaCard component's behavior and styling based on background presence, as both involve handling properties that affect the visual representation of call-to-action elements.

Poem

In the code garden I hop with cheer,
Constructors vanish like dew in the morn;
Tests now whisper with strings crystal clear,
Default paths reborn from what was once torn.
Each change a nibble on innovation’s delight,
A bunny’s ode to a codebase shining bright!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd972e4 and 4de5ce5.

📒 Files selected for processing (4)

• packages/kg-default-nodes/lib/nodes/call-to-action/CallToActionNode.js (1 hunks)
• packages/kg-default-nodes/test/nodes/call-to-action.test.js (1 hunks)
• packages/koenig-lexical/src/components/ui/cards/CtaCard.stories.jsx (2 hunks)
• packages/koenig-lexical/src/nodes/CallToActionNode.jsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/koenig-lexical/src/components/ui/cards/CtaCard.stories.jsx

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/kg-default-nodes/test/nodes/call-to-action.test.js

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Node 20.11.1

🔇 Additional comments (2)

packages/kg-default-nodes/lib/nodes/call-to-action/CallToActionNode.js (1)

4-20: LGTM! Good cleanup of redundant initialization logic.

The removal of the custom constructor is a good improvement as it:

• Eliminates potential inconsistencies between constructor defaults and properties array defaults
• Leverages the existing initialization logic in generateDecoratorNode
• Makes the code more maintainable by centralizing default values in the properties array

packages/koenig-lexical/src/nodes/CallToActionNode.jsx (1)

80-80: Verify the wrapperStyle behavior with different backgroundColor values.

The change from checking backgroundColor === 'none' to a truthy check (backgroundColor ? 'regular' : 'wide') may have different behavior for falsy values like empty string or undefined. Please ensure this aligns with the expected styling behavior.

Run the following script to check the usage of backgroundColor in tests and components:

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.