Added new template mapping for using Rettiwt provider #1409
+329
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldlangeveld
commented
Jan 20, 2025
Comment on lines
+103
to
+112
| const tcoLinks = formattedContent.match(/https:\/\/t\.co\/[a-zA-Z0-9]+/g) || []; | ||
| const displayUrls = urls.map(urlObj => urlObj.display_url); | ||
| tcoLinks.forEach((tcoLink, index) => { | ||
| if (index < displayUrls.length) { | ||
| formattedContent = formattedContent.replace( | ||
| tcoLink, | ||
| wrapWithStyle(displayUrls[index], 'color: #1DA1F2; word-break: break-all;') | ||
| ); | ||
| } | ||
| }); |
There was a problem hiding this comment.
With Rettiwt we don't have the start / end positioning of links like we have with the official API, in order to replace the shortened link with the actual link for better aesthetics.
However we do get an array with the urls from the tweet eg ['https://url1.com', 'https://url2.com'] and based on manual experimenting they appear in the order of which links appear in a post - however I don't think that's guaranteed based on the documentation.
Do you think it's worth the risk of a potential bad render should the ordering not render in the order as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-1792