Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

✨ add spellcheck toggle #697

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented May 16, 2017

closes TryGhost/Ghost#8461

  • adds toggle spellcheck button to the gh-markdown-editor toolbar
  • adds custom styles to fake a spellcheck icon
  • updates simplemde fork
    • adds spellcheck to the list of toolbar buttons that don't have their active class removed based on cursor position
    • removes bundled marked dependency that we no longer use

TODO:

  • ensure button doesn't lose active state when cursor is placed in content

spellcheck-toggle

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 71.299% when pulling 9b68d77 on kevinansfield:spellcheck-toggle into fac2560 on TryGhost:master.

@kevinansfield kevinansfield changed the title ✨ add spellcheck toggle [WIP] ✨ add spellcheck toggle May 16, 2017
closes TryGhost/Ghost#8461
- adds toggle spellcheck button to the `gh-markdown-editor` toolbar
- adds custom styles to fake a spellcheck icon
- updates `simplemde` fork
  - adds `spellcheck` to the list of toolbar buttons that don't have their `active` class removed based on cursor position
  - removes bundled `marked` dependency that we no longer use
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 71.299% when pulling a7debf6 on kevinansfield:spellcheck-toggle into 24c02ac on TryGhost:master.

@kevinansfield kevinansfield changed the title [WIP] ✨ add spellcheck toggle ✨ add spellcheck toggle May 17, 2017
@kevinansfield kevinansfield requested a review from aileen May 17, 2017 11:34
Copy link
Member

@aileen aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the initial state (first load and after refresh) of the spellcheck box is active, but doesn't work.

spell_toggle

@kevinansfield
Copy link
Member Author

@AileenCGN that's the way CodeMirror's spell check works - it doesn't trigger the spell check until first edit and the behaviour is the same with or without this PR. If we want to fix that it's probably worth opening a separate issue.

@aileen
Copy link
Member

aileen commented May 18, 2017

Ah... Ok. I just found it very confusing, because it seems to be activated, but isn't until I toggle the spellcheck off and on again.

@kevinansfield
Copy link
Member Author

There's an open issue on the spell checker plugin here sparksuite/codemirror-spell-checker#28 - proposed solutions (one of which is almost a complete rewrite) haven't been incorporated into the main library. We could fork the spell checker plugin and incorporate a fix into our own simplemde fork if needed.

@aileen aileen merged commit ef9381b into TryGhost:master May 18, 2017
@kevinansfield kevinansfield deleted the spellcheck-toggle branch June 4, 2018 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toggle for spellcheck
3 participants