[feat] 여행후기 기본 구현 완료 #39
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package com.haejwo.tripcometrue.domain.triprecord.controller; | ||
|
|
||
| import com.haejwo.tripcometrue.domain.triprecord.dto.request.TripRecordRequestDto; | ||
| import com.haejwo.tripcometrue.domain.triprecord.dto.response.TripRecordResponseDto; | ||
| import com.haejwo.tripcometrue.domain.triprecord.service.TripRecordService; | ||
| import com.haejwo.tripcometrue.global.util.ResponseDTO; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.DeleteMapping; | ||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.PathVariable; | ||
| import org.springframework.web.bind.annotation.PostMapping; | ||
| import org.springframework.web.bind.annotation.PutMapping; | ||
| import org.springframework.web.bind.annotation.RequestBody; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/v1/trip-record") | ||
| @RequiredArgsConstructor | ||
| public class TripRecordController { | ||
|
|
||
| private final TripRecordService tripRecordService; | ||
|
|
||
| @PostMapping | ||
| public ResponseEntity<ResponseDTO<TripRecordResponseDto>> tripRecordAdd( | ||
|
There was a problem hiding this comment. 컨트롤러의 메소드에선 서비스 계층의 메소드와 다르게 동사를 뒤에 배치한 이유가 있나요? There was a problem hiding this comment. 구분을 위해서 그렇게 했습니다. There was a problem hiding this comment. 아하 그렇군요! 제가 알기로도 정해진 건 없다고 들었습니다! 메소드명까지 굳이 통일할 필요가 없다면 재량껏 사용해도 될듯 해요. 다른 분들은 어떻게 생각하시는지 궁금하네요 ㅎㅎ |
||
| @RequestBody TripRecordRequestDto requestDto | ||
| ) { | ||
|
|
||
| TripRecordResponseDto responseDto = tripRecordService.addTripRecord(requestDto); | ||
| ResponseDTO<TripRecordResponseDto> responseBody = ResponseDTO.okWithData(responseDto); | ||
|
|
||
| return ResponseEntity | ||
|
There was a problem hiding this comment. 등록한 여행 후기 내용 전체를 다시 프론트로 돌려주는 이유가 있나요? There was a problem hiding this comment. 이건 그냥 습관, 성향 차이로 알고 있습니다. |
||
| .status(responseBody.getCode()) | ||
| .body(responseBody); | ||
| } | ||
|
|
||
| @GetMapping("/{tripRecordId}") | ||
| public ResponseEntity<ResponseDTO<TripRecordResponseDto>> tripRecordDetails( | ||
| @PathVariable Long tripRecordId | ||
| ) { | ||
|
|
||
| TripRecordResponseDto responseDto = tripRecordService.findTripRecord(tripRecordId); | ||
| ResponseDTO<TripRecordResponseDto> responseBody = ResponseDTO.okWithData(responseDto); | ||
|
|
||
| return ResponseEntity | ||
| .status(responseBody.getCode()) | ||
| .body(responseBody); | ||
| } | ||
|
|
||
| @PutMapping("/{tripRecordId}") | ||
| public ResponseEntity<ResponseDTO<TripRecordResponseDto>> tripRecordModify( | ||
| @PathVariable Long tripRecordId, | ||
| @RequestBody TripRecordRequestDto requestDto | ||
| ) { | ||
|
|
||
| TripRecordResponseDto responseDto = tripRecordService.modifyTripRecord(tripRecordId, requestDto); | ||
| ResponseDTO<TripRecordResponseDto> responseBody = ResponseDTO.okWithData(responseDto); | ||
|
|
||
| return ResponseEntity | ||
| .status(responseBody.getCode()) | ||
| .body(responseBody); | ||
|
|
||
| } | ||
|
|
||
| @DeleteMapping("/{tripRecordId}") | ||
| public ResponseEntity<ResponseDTO> tripRecordRemove( | ||
| @PathVariable Long tripRecordId | ||
| ) { | ||
|
|
||
| tripRecordService.removeTripRecord(tripRecordId); | ||
| ResponseDTO responseBody = ResponseDTO.ok(); | ||
|
|
||
| return ResponseEntity | ||
| .status(responseBody.getCode()) | ||
| .body(responseBody); | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package com.haejwo.tripcometrue.domain.triprecord.dto.request; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonFormat; | ||
| import com.haejwo.tripcometrue.domain.triprecord.entity.ExpenseRangeType; | ||
| import com.haejwo.tripcometrue.domain.triprecord.entity.TripRecord; | ||
| import java.time.LocalDate; | ||
| import lombok.Builder; | ||
|
|
||
| public record TripRecordRequestDto( | ||
| String title, | ||
| String content, | ||
| ExpenseRangeType expenseRangeType, | ||
| @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd") LocalDate tripStartDay, | ||
| @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd") LocalDate tripEndDay, | ||
| String countries | ||
| ) { | ||
|
|
||
| @Builder | ||
| public TripRecordRequestDto(String title, String content, ExpenseRangeType expenseRangeType, | ||
| LocalDate tripStartDay, LocalDate tripEndDay, String countries) { | ||
| this.title = title; | ||
| this.content = content; | ||
| this.expenseRangeType = expenseRangeType; | ||
| this.tripStartDay = tripStartDay; | ||
| this.tripEndDay = tripEndDay; | ||
| this.countries = countries; | ||
| } | ||
|
|
||
| public TripRecord toEntity() { | ||
| return TripRecord.builder() | ||
| .title(this.title) | ||
| .content(this.content) | ||
| .expenseRangeType(this.expenseRangeType) | ||
| .tripStartDay(this.tripStartDay) | ||
| .tripEndDay(this.tripEndDay) | ||
| .countries(this.countries) | ||
| .build(); | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL에 도메인을 어떻게 표시할지는 추후에 논의해서 통일하면 좋을듯 합니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
원래는 restful 기준에 따르면 소문자와 - _ 이 두개로 표현하는게 정석으로 알고 있습니다.