feat: TS unit and integration tests #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perfectra1n
approved these changes
Jun 17, 2024
…ntegration-tests ; Conflicts: ; package.json ; tsconfig.json
eliandoran
approved these changes
Jul 15, 2024
|
@alexpietsch , thank you for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49
In general, the tests should run. But they run very inconsistent.
E.g. the jasmine tests: Most of the time, I have to uninstall and reinstall the node_modules before every run. Otherwise, the etapi tests time out. (I expect the
beforeEachandafterEachto run inconsistent).Also, the results for almost all search tests are wrong (see #162). I wasn't able to figure out why.
And one last note: I skipped the import test, because the used file
test-export.zipis missing.So in general: We need to rework the tests, and find a more reliable way for the etapi tests for the starting and stopping of the server.