Merge pull request #559 from TriliumNext/siriusxt-test

Make attachments open in a new tab/browser
TriliumNext · Nov 7, 2024 · b5988ba · b5988ba
2 parents a02146d + d2ee373
commit b5988ba
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/public/app/widgets/type_widgets/abstract_text_type_widget.js b/src/public/app/widgets/type_widgets/abstract_text_type_widget.js
@@ -32,16 +32,16 @@ export default class AbstractTextTypeWidget extends TypeWidget {
 
     async openImageInCurrentTab($img) {
         const { noteId, viewScope } = await this.parseFromImage($img);
-
+        
         if (noteId) {
             appContext.tabManager.getActiveContext().setNote(noteId, { viewScope });
         } else {
             window.open($img.prop("src"), '_blank');
         }
     }
 
-    openImageInNewTab($img) {
-        const { noteId, viewScope } = this.parseFromImage($img);
+    async openImageInNewTab($img) {
+        const { noteId, viewScope } = await this.parseFromImage($img);
 
         if (noteId) {
             appContext.tabManager.openTabWithNoteWithHoisting(noteId, { viewScope });

diff --git a/src/services/window.ts b/src/services/window.ts
@@ -111,13 +111,9 @@ async function createMainWindow(app: App) {
 }
 
 function configureWebContents(webContents: WebContents, spellcheckEnabled: boolean) {
-    if (!mainWindow) {
-        return;
-    }
-
     remoteMain.enable(webContents);
 
-    mainWindow.webContents.setWindowOpenHandler((details) => {
+    webContents.setWindowOpenHandler((details) => {
         async function openExternal() {
             (await import('electron')).shell.openExternal(details.url);
         }