Use Default dispatcher instead of Main in Community scope. #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coroutineScope in the Community class uses
Dispatchers.Main
.Dispatchers.Main
is used to run code on the UI thread and should not be used for anything else.Code that uses the scope without specifying the Dispatcher when launching a new task (like eva), does not work on a PC, as you need another dependency to access the Main dispatcher.
kotlin-ipv8/ipv8/src/main/java/nl/tudelft/ipv8/messaging/eva/EVAProtocol.kt
Line 74 in f983ed4
https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines/-dispatchers/-main.html