Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1836] Rename is conversion method and add from string conversions… #7135

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[NU-1836] Rename is conversion method and add from string conversions… #7135

merged 3 commits into from
Nov 13, 2024

Conversation

lukasz-bigorajski
Copy link
Contributor

… methods

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Nov 8, 2024
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1836.invoke.extension.methods.statically.1 branch 2 times, most recently from 0d84e8f to 18281f9 Compare November 13, 2024 14:01
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1836.rename.is.conversion.method.and.add.from.string.conversions.methods branch from 742991b to a5862b4 Compare November 13, 2024 14:20
Base automatically changed from nu.1836.invoke.extension.methods.statically.1 to release/1.18 November 13, 2024 15:25
Łukasz Bigorajski added 3 commits November 13, 2024 16:31
[NU-1836] Rename is conversion method and add from string conversions…
4d73428 
… methods

# Conflicts:
#	docs/Changelog.md
#	scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/CastOrConversionExt.scala
#	scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ConversionExt.scala
rename in suggester spec
bdd7adb
rebase
10e8fd9
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1836.rename.is.conversion.method.and.add.from.string.conversions.methods branch from a5862b4 to 10e8fd9 Compare November 13, 2024 15:34
@lukasz-bigorajski lukasz-bigorajski merged commit 89ed14a into release/1.18 Nov 13, 2024
16 of 17 checks passed
@lukasz-bigorajski lukasz-bigorajski deleted the nu.1836.rename.is.conversion.method.and.add.from.string.conversions.methods branch November 13, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasz-bigorajski @arkadius