Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1661] Remove focus from input in a dialog on esc keyboard button click #7106

Conversation

Dzuming
Copy link
Contributor

@Dzuming Dzuming commented Oct 29, 2024

Describe your changes

  • Remove focus from input/textarea/select in the window ONLY on esc button clicks
Screen.Recording.2024-10-29.at.13.11.17.mov

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Oct 29, 2024
@Dzuming Dzuming merged commit 6d63f6d into staging Oct 31, 2024
13 checks passed
@Dzuming Dzuming deleted the NU-1661-remove-focus-from-input-in-a-dialog-on-esc-keyboard-button-click branch October 31, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants