Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NU-1848: Flink base types registration mechanism #7097

Merged
merged 4 commits into from
Oct 29, 2024
Merged

NU-1848: Flink base types registration mechanism #7097

merged 4 commits into from
Oct 29, 2024

Conversation

lciolecki
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@lciolecki lciolecki force-pushed the imp/flink-base-type-info branch 3 times, most recently from 238ca2f to 88224db Compare October 28, 2024 14:35
@lciolecki lciolecki marked this pull request as draft October 29, 2024 06:09
@lciolecki lciolecki changed the title Improvement: FlinkBaseTypeInfoRegister mechanism Improvement: Flink base types registration mechanism Oct 29, 2024
@github-actions github-actions bot added the docs label Oct 29, 2024
@lciolecki lciolecki changed the title Improvement: Flink base types registration mechanism NU-1848: Flink base types registration mechanism Oct 29, 2024
@lciolecki lciolecki marked this pull request as ready for review October 29, 2024 08:33
@lciolecki lciolecki force-pushed the imp/flink-base-type-info branch 2 times, most recently from 05c6d60 to df625b6 Compare October 29, 2024 08:36
arkadius
arkadius approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks added only. Merge it after fixing them.

...n/scala/pl/touk/nussknacker/engine/flink/api/typeinformation/FlinkBaseTypeInfoRegister.scala Outdated Show resolved Hide resolved
...n/scala/pl/touk/nussknacker/engine/flink/api/typeinformation/FlinkBaseTypeInfoRegister.scala Outdated Show resolved Hide resolved
...n/scala/pl/touk/nussknacker/engine/flink/api/typeinformation/FlinkBaseTypeInfoRegister.scala Outdated Show resolved Hide resolved
@lciolecki lciolecki merged commit 0787421 into staging Oct 29, 2024
17 of 18 checks passed
@lciolecki lciolecki deleted the imp/flink-base-type-info branch October 29, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lciolecki @arkadius