Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1836] Move converters from CONV util to extension methods. Implement generic conversion extension methods: is, to and toOrNull. #7063

Merged
merged 11 commits into from
Oct 30, 2024
Merged

[NU-1836] Move converters from CONV util to extension methods. Implement generic conversion extension methods: is, to and toOrNull. #7063

merged 11 commits into from
Oct 30, 2024

Conversation

lukasz-bigorajski
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Oct 23, 2024
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1836.rename.casting.methods branch 3 times, most recently from 284c362 to 494a0c7 Compare October 24, 2024 12:28
@lukasz-bigorajski lukasz-bigorajski changed the title [NU-1836] Rename casting methods [NU-1836] Move converters from CONV util to extension methods. Implement generic conversion extension methods: is, to and toOrNull. Oct 24, 2024
arkadius
arkadius reviewed Oct 28, 2024
View reviewed changes
components-api/src/main/scala/pl/touk/nussknacker/engine/api/typed/typing.scala Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ExpressionSuggesterSpec.scala Show resolved Hide resolved
docs/Changelog.md Outdated Show resolved Hide resolved
docs/scenarios_authoring/Spel.md Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Conversion.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Conversion.scala Outdated Show resolved Hide resolved
...o-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/CollectionConversionExt.scala Outdated Show resolved Hide resolved
...o-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/CollectionConversionExt.scala Outdated Show resolved Hide resolved
...o-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/CollectionConversionExt.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Conversion.scala Outdated Show resolved Hide resolved
arkadius
arkadius reviewed Oct 28, 2024
View reviewed changes
docs/scenarios_authoring/Spel.md Show resolved Hide resolved
docs/scenarios_authoring/Spel.md Outdated Show resolved Hide resolved
arkadius
arkadius reviewed Oct 28, 2024
View reviewed changes
docs/Changelog.md Outdated Show resolved Hide resolved
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1836.rename.casting.methods branch 2 times, most recently from c61be12 to 08b5370 Compare October 29, 2024 21:12
Łukasz Bigorajski added 9 commits October 30, 2024 13:05
[NU-1836] Move converters from CONV util to extension methods. Implem…
4aac60c 
…ent generic conversion extension methods: is, to and toOrNull.

# Conflicts:
#	docs/Changelog.md

# Conflicts:
#	docs/Changelog.md

# Conflicts:
#	scenario-compiler/src/test/scala/pl/touk/nussknacker/engine/extension/ExtensionMethodsSpec.scala

# Conflicts:
#	scenario-compiler/src/test/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSpec.scala
review fixes
91c4168
review fixes 2
5b7f962
review fixes 3
55ac525
review fixes 4
5b0a4c9
review fixes 5
9616e0b
review fixes 6
04116a9
review fixes 7
7aaab63
review fixes 8
956f6be
arkadius
arkadius approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@lukasz-bigorajski lukasz-bigorajski merged commit 333afd6 into staging Oct 30, 2024
18 checks passed
@lukasz-bigorajski lukasz-bigorajski deleted the nu.1836.rename.casting.methods branch October 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasz-bigorajski @arkadius