-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend validation for Adhoc testing #6944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Dzuming
reviewed
Sep 25, 2024
designer/client/src/components/graph/node-modal/editors/expression/Formatter.ts
Outdated
Show resolved
Hide resolved
arkadius
reviewed
Sep 26, 2024
designer/server/src/main/scala/pl/touk/nussknacker/ui/validation/ParametersValidator.scala
Outdated
Show resolved
Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/validation/ParametersValidator.scala
Outdated
Show resolved
Hide resolved
philemone
force-pushed
the
adhoc-validation
branch
4 times, most recently
from
September 30, 2024 11:43
59aedae
to
d5a9006
Compare
created: #6993 |
philemone
force-pushed
the
adhoc-validation
branch
from
September 30, 2024 13:10
00d2411
to
bba1e43
Compare
philemone
force-pushed
the
adhoc-validation
branch
2 times, most recently
from
September 30, 2024 14:23
df99c3f
to
4889ded
Compare
arkadius
reviewed
Sep 30, 2024
designer/server/src/main/scala/pl/touk/nussknacker/ui/validation/ParametersValidator.scala
Outdated
Show resolved
Hide resolved
arkadius
reviewed
Sep 30, 2024
arkadius
reviewed
Sep 30, 2024
Dzuming
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
philemone
force-pushed
the
adhoc-validation
branch
2 times, most recently
from
October 7, 2024 07:46
39b901d
to
0b0f139
Compare
philemone
force-pushed
the
adhoc-validation
branch
from
October 7, 2024 08:27
0b0f139
to
cdb73b0
Compare
philemone
force-pushed
the
adhoc-validation
branch
from
October 7, 2024 10:54
cdb73b0
to
1b1a138
Compare
philemone
force-pushed
the
adhoc-validation
branch
from
October 7, 2024 11:38
1b1a138
to
8bbec9c
Compare
arkadius
approved these changes
Oct 10, 2024
* Extend ParametersValidator to handle validators as well * Change string formatter to remove quotes when changed value is empty.
…only quotes as empty value
- Rewrite akka routes to tapir for /scenarioTesting - Add new tests for scenarioTesting service - Remove /testInfo resources and tests (replaced by scenarioTesting tests)
philemone
force-pushed
the
adhoc-validation
branch
from
October 10, 2024 10:50
a6b2f30
to
83f680b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Right now adhoc testing only validates types of expression, not validators. This MR adds new endpoint for adhoc testing to move all parameters validation to backend.
It addition this MR adds change to string formatter to remove single quotes while no value is stored inside string field.
Checklist before merge