Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend validation for Adhoc testing #6944

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Conversation

philemone
Copy link
Contributor

@philemone philemone commented Sep 25, 2024

Describe your changes

Right now adhoc testing only validates types of expression, not validators. This MR adds new endpoint for adhoc testing to move all parameters validation to backend.
It addition this MR adds change to string formatter to remove single quotes while no value is stored inside string field.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

created: #6993
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

docs/MigrationGuide.md Outdated Show resolved Hide resolved
docs/Changelog.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Extend ParametersValidator to handle validators as well
* Change string formatter to remove quotes when changed value is empty.
@philemone philemone merged commit ace3825 into staging Oct 10, 2024
10 checks passed
@philemone philemone deleted the adhoc-validation branch October 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants