Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1701] Introduce extension methods to SpeL. Add canCastTo and cast… #6875

Merged
merged 17 commits into from
Oct 1, 2024
Merged

[NU-1701] Introduce extension methods to SpeL. Add canCastTo and cast… #6875

merged 17 commits into from
Oct 1, 2024

Conversation

lukasz-bigorajski
Copy link
Contributor

…To to SpeL.

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Sep 16, 2024
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1701.refactor.class.definition.extractor branch from 20f060f to ba7377e Compare September 18, 2024 06:28
Base automatically changed from nu.1701.refactor.class.definition.extractor to staging September 18, 2024 12:14
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1701.add.can.cast.to.and.cast.to.functions.to.spel branch 4 times, most recently from b2068d7 to d1a67f3 Compare September 23, 2024 11:05
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

created: #6967
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1701.add.can.cast.to.and.cast.to.functions.to.spel branch 3 times, most recently from ff03411 to e9915fd Compare September 25, 2024 12:20
@github-actions github-actions bot added client client main fe ui labels Sep 25, 2024
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Closed
mslabek
mslabek approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@mslabek mslabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nonblocking comments from me. Other than that, LGTM!

benchmarks/src/test/scala/pl/touk/nussknacker/engine/benchmarks/spel/SpelBenchmarkSetup.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Cast.scala Outdated Show resolved Hide resolved
arkadius
arkadius reviewed Sep 27, 2024
View reviewed changes
...main/scala/pl/touk/nussknacker/engine/extension/ClassDefinitionSetWithExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ExtensionMethods.scala Outdated Show resolved Hide resolved
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1701.add.can.cast.to.and.cast.to.functions.to.spel branch from cbe73c5 to 7ec6d19 Compare September 27, 2024 14:42
@github-actions github-actions bot removed ui client client main fe labels Sep 27, 2024
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1701.add.can.cast.to.and.cast.to.functions.to.spel branch from 7ec6d19 to 950cf3c Compare September 29, 2024 19:17
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1701.add.can.cast.to.and.cast.to.functions.to.spel branch from 950cf3c to 6984283 Compare September 29, 2024 19:17
arkadius
arkadius reviewed Sep 30, 2024
View reviewed changes
...main/scala/pl/touk/nussknacker/engine/extension/ClassDefinitionSetWithExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Cast.scala Outdated Show resolved Hide resolved
...main/scala/pl/touk/nussknacker/engine/extension/ClassDefinitionSetWithExtensionMethods.scala Outdated Show resolved Hide resolved
...main/scala/pl/touk/nussknacker/engine/extension/ClassDefinitionSetWithExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Cast.scala Outdated Show resolved Hide resolved
...piler/src/main/scala/pl/touk/nussknacker/engine/extension/AllowedCastParametersClasses.scala Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Closed
arkadius
arkadius approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change

@lukasz-bigorajski lukasz-bigorajski merged commit 0b0373c into staging Oct 1, 2024
18 checks passed
@lukasz-bigorajski lukasz-bigorajski deleted the nu.1701.add.can.cast.to.and.cast.to.functions.to.spel branch October 1, 2024 13:11
@lukasz-bigorajski lukasz-bigorajski mentioned this pull request Oct 4, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mslabek mslabek mslabek approved these changes

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasz-bigorajski @arkadius @mslabek