Display user-relative date , disable pdf/undo/redo buttons when needed, change some labels #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mproch
reviewed
Oct 21, 2019
ui/client/common/DateUtils.js
Outdated
| return dateTimeString.replace("T", " | ").substring(0, 18) | ||
| } | ||
|
|
||
| format(dateTimeString) { |
There was a problem hiding this comment.
do we really want this? I think our users will be a bit confused. There must be at least some way of showing absolute date...
There was a problem hiding this comment.
What would you say if the absolute date would be displayed "on mouse over" specified date?
lciolecki
reviewed
Oct 21, 2019
| {name: "export", onClick: this.exportProcess, icon: InlinedSvgs.buttonExport}, | ||
| {name: "exportPDF", disabled: !this.props.nothingToSave, onClick: this.exportProcessToPdf, icon: InlinedSvgs.buttonExport}, | ||
| {name: "export", disabled: this.props.nothingToExport, onClick: this.exportProcess, icon: InlinedSvgs.buttonExport}, | ||
| {name: "PDF", disabled: this.props.nothingToExport, onClick: this.exportProcessToPdf, icon: InlinedSvgs.pdf}, |
There was a problem hiding this comment.
Sorry, I forgot to include link to this issue: #171
There was a problem hiding this comment.
Okay, so leave it as PDF, but maybe in export we can put JSON?
There was a problem hiding this comment.
Oh, I have an idea: at title put full description like: Export to PDF file. And at rest of buttons you can add similar full description.
There was a problem hiding this comment.
Good idea, will apply that
PPiedel
force-pushed
the
use_user_relative_date
branch
from
f73df1a
to
4747595
Compare
…d, change pdf icon, rename some labels
PPiedel
force-pushed
the
use_user_relative_date
branch
from
4747595
to
2aec439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #230
This resolves #187
This resolves #186
This resolves #177
This resolves #171