review fixes 5

TouK · Sep 20, 2024 · f0f6cf6 · f0f6cf6
1 parent 4190e76
commit f0f6cf6
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/...a/pl/touk/nussknacker/engine/benchmarks/suggester/ExpressionSuggesterBenchmarkSetup.scala b/...a/pl/touk/nussknacker/engine/benchmarks/suggester/ExpressionSuggesterBenchmarkSetup.scala
@@ -43,7 +43,8 @@ class ExpressionSuggesterBenchmarkSetup() {
     clazzDefinitions,
     dictServices,
     getClass.getClassLoader,
-    List.empty
+    List.empty,
+    ClassDefinitionTestUtils.DefaultSettings
   )
 
   private val variables: Map[String, TypingResult] = Map(

diff --git a/designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ExpressionSuggesterSpec.scala b/designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ExpressionSuggesterSpec.scala
@@ -133,7 +133,8 @@ class ExpressionSuggesterSpec
     clazzDefinitions,
     dictServices,
     getClass.getClassLoader,
-    List("scenarioProperty")
+    List("scenarioProperty"),
+    ClassDefinitionTestUtils.DefaultSettings
   )
 
   private val localVariables: Map[String, TypingResult] = Map(

diff --git a/...-compiler/src/main/scala/pl/touk/nussknacker/engine/spel/typer/MethodReferenceTyper.scala b/...-compiler/src/main/scala/pl/touk/nussknacker/engine/spel/typer/MethodReferenceTyper.scala
@@ -1,16 +1,15 @@
 package pl.touk.nussknacker.engine.spel.typer
 
-import cats.data.{NonEmptyList, ValidatedNel}
 import cats.data.Validated.{Invalid, Valid}
+import cats.data.{NonEmptyList, ValidatedNel}
 import pl.touk.nussknacker.engine.api.generics.ExpressionParseError
 import pl.touk.nussknacker.engine.api.typed.typing._
-import pl.touk.nussknacker.engine.definition.clazz.{ClassDefinition, ClassDefinitionSet, MethodDefinition}
+import pl.touk.nussknacker.engine.definition.clazz.{ClassDefinition, MethodDefinition}
 import pl.touk.nussknacker.engine.extension.ClassDefinitionSetExtensionMethodsAware
 import pl.touk.nussknacker.engine.spel.SpelExpressionParseError.IllegalOperationError.IllegalInvocationError
 import pl.touk.nussknacker.engine.spel.SpelExpressionParseError.MissingObjectError.UnknownMethodError
 import pl.touk.nussknacker.engine.spel.SpelExpressionParseError.{ArgumentTypeError, OverloadedFunctionError}
 
-// todo: lbg imports
 class MethodReferenceTyper(
     classDefinitionSet: ClassDefinitionSetExtensionMethodsAware,
     methodExecutionForUnknownAllowed: Boolean

diff --git a/...fault-helpers/src/test/scala/pl/touk/nussknacker/engine/util/functions/BaseSpelSpec.scala b/...fault-helpers/src/test/scala/pl/touk/nussknacker/engine/util/functions/BaseSpelSpec.scala
@@ -37,6 +37,7 @@ trait BaseSpelSpec {
     enableSpelForceCompile = false,
     SpelExpressionParser.Standard,
     classDefinitions,
+    ClassDefinitionTestUtils.DefaultSettings
   )
 
   private lazy val classDefinitions = ClassDefinitionTestUtils.createDefinitionForClasses(

diff --git a/.../test/scala/pl/touk/nussknacker/engine/schemedkafka/typed/SpelExpressionSchemedSpec.scala b/.../test/scala/pl/touk/nussknacker/engine/schemedkafka/typed/SpelExpressionSchemedSpec.scala
@@ -25,7 +25,8 @@ class SpelExpressionSchemedSpec extends AnyFunSuite with Matchers with Validated
     new SimpleDictRegistry(Map.empty),
     enableSpelForceCompile = false,
     Standard,
-    ClassDefinitionTestUtils.createDefinitionForClasses(classOf[GenericRecord])
+    ClassDefinitionTestUtils.createDefinitionForClasses(classOf[GenericRecord]),
+    ClassDefinitionTestUtils.DefaultSettings
   )
 
   test("compute avro record's get type based on type of fields") {