Add SM4 encryption and decryption API #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itomsawyer
reviewed
Dec 5, 2023
examples/sm4/sm4
Outdated
There was a problem hiding this comment.
Executable binary file committed by mistake
itomsawyer
reviewed
Dec 5, 2023
examples/sm3/sm3
Outdated
There was a problem hiding this comment.
Executable binary file committed by mistake
itomsawyer
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Consider move sm4.go to crypto/sm4/sm4.go as well as sm4_test.go
There was a problem hiding this comment.
sm4.go is based on ciphers.go，unless I move ciphers.go to crypto directory together.
And in the future we may have aes.go and other symmetric cipher, it's better to reuse ciphers.go.
There was a problem hiding this comment.
Sure, refactor ciphers can be done in the future.
Add SM4 API, including ECB, CBC, CFB, OFC, CTR, GCM, and CCM mode. Delete useless C code. Fix readme.
dongbeiouba
force-pushed
the
examples/ntls
branch
from
81660f9 to
2aff30d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SM4 API, including ECB, CBC, CFB, OFC, CTR, GCM, and CCM mode.
Delete useless C code.
Fix readme.