Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[서인] 주문내역 상세 페이지 / 성능 개선 #319

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

Seoin02
Copy link
Contributor

@Seoin02 Seoin02 commented Jul 31, 2024

🔥관련 이슈

😁주요 변경 사항

  • BackButton aria-label 속성 추가 => 웹 접근성 개선
  • 주문내역 상세 페이지 요소 세로 고정값 지정 => CLS 개선
  • Card Image 컴포넌트에 quality 속성 추가 => LCP 개선

📄스크린샷


스크린샷 2024-08-03 오전 8 24 01

📝전달사항(세심하게 봐야 할 부분 / 고민점)

  • 페이지 성능(CLS) 0.259에서 0.014로 94.6% 개선해 안정적인 레이아웃 구현

💌리뷰 작성

칭찬: 👍 / 수정 요청: ❗ / 질문: ❓ / 제안: 💊 / 여담: 💬

@Seoin02 Seoin02 linked an issue Jul 31, 2024 that may be closed by this pull request
3 tasks
Copy link

🐾 포잉마켓 미리보기: https://pawing-market-bhxgx2ozl-devwqcs-projects.vercel.app

Copy link

🐾 포잉마켓 미리보기: https://pawing-market-eo6dtb7l1-devwqcs-projects.vercel.app

Copy link

🐾 포잉마켓 미리보기: https://pawing-market-4jwomoyt6-devwqcs-projects.vercel.app

Copy link

🐾 포잉마켓 미리보기: https://pawing-market-luoupykl3-devwqcs-projects.vercel.app

@Seoin02 Seoin02 changed the title 리뷰하지 마세여[서인] 주문내역 상세 페이지 / 성능 개선 [서인] 주문내역 상세 페이지 / 성능 개선 Jul 31, 2024
@Seoin02 Seoin02 self-assigned this Jul 31, 2024
@Seoin02 Seoin02 marked this pull request as ready for review July 31, 2024 16:28
Copy link
Member

@devwqc devwqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서인님 감사합니다~ ✨👼✨👼✨👼✨👼✨👼✨👼

CSS 수정으로도 성능 개선이 가능하군요?!
aria- 속성에 대해서 저도 본 적 있었는데 직접 적용까지 하시다니👍

@Seoin02 Seoin02 merged commit 693bf96 into develop Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 주문내역 페이지 / LCP, CLS 성능 개선
2 participants