fix race condition that can cause a use after free #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backported from 12a0ccd6f7201bac706d903ac3f436c4358fe203. Bug: 33004354 Test: manual Change-Id: I9b38ee644b02268c9b995a330db758aa2e568399 (cherry picked from commit 5948552)
Avoid getprop() calls in performance critical display code paths. Instead of querying the property each time we need it, we read it once during initialization and then reuse the cached value. This is more appropriate here because we do not expect the value to change at runtime. In fact, this property behaves like a compile time constant in the real world: Set it once and never again (because the angle of your panel is fixed and does not change after the device leaves the factory). Change-Id: I55c4131735a65c7bdde8b00c166913bffa6c4ec3
* Needed for Google SetupWizard to start * Without this, SetupWizard is compiled by ART on boot and runs out of memory (heap) while running, resulting in the SetupWizard crashing and blocking boot Change-Id: Ic5b8caf4352f6d104af9121a09a01adad1c5bcc3 Signed-off-by: Adrian DC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from 12a0ccd6f7201bac706d903ac3f436c4358fe203.
Bug: 33004354
Test: manual
Change-Id: I9b38ee644b02268c9b995a330db758aa2e568399
(cherry picked from commit 5948552)