Remove abomonation
to reduce unsoundness
#575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unsafe
keyword is the source of unsoundness in Rust, and we would like to minimize it. One particular villain (by its own admission) is abomonation, which provides unsafe serialization and deserialization in the name of performance. Although performance is great, the unsoundness that results from usingunsafe
is not.This PR does not evaluate any performance considerations, nor does it even test whether
bincode
is a suitable replacement in the contexts in which it is used. Probably worth shaking that out before merging anything.