Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal Core variants #551

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

frankmcsherry
Copy link
Member

@frankmcsherry frankmcsherry commented Mar 21, 2024

We have several "largely internal" types that are suffixed with Core in an abundance of caution about breaking external uses. That caution is now gone, and we are going to start looking at changes that introduce the opinion that containers are the "right" least common denominator approach to using TD, and Vec containers are mostly an ergonomic layer on top of them (and some amount of performance anti-pattern).

There are other Core types that are less internal, things like StreamCore, HandleCore, and others. We'll eventually want to rationalize those as well, but they are likely to be very breaking rather than lightly breaking, and the migration there will probably look more like the type stuff we have at the moment (though likely in some dataflow::vec module, rather than implicitly recommended for everyone).

@frankmcsherry frankmcsherry merged commit 786326d into TimelyDataflow:master Mar 21, 2024
1 check passed
@frankmcsherry frankmcsherry deleted the core_rename branch March 21, 2024 16:42
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant