Inline functions frequently called from Materialize #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
commented
Jun 9, 2023
| @@ -81,6 +84,7 @@ impl<T: Columnation> TimelyStack<T> { | |||
| /// Retain elements that pass a predicate, from a specified offset. | |||
| /// | |||
| /// This method may or may not reclaim memory in the inner region. | |||
| #[inline] | |||
There was a problem hiding this comment.
Check if this is actually helpful.
| @@ -495,6 +495,7 @@ impl<T> MutableAntichain<T> { | |||
| /// This method is meant to be used for bulk updates to the frontier, and does more work than one might do | |||
| /// for single updates, but is meant to be an efficient way to process multiple updates together. This is | |||
| /// especially true when we want to apply very large numbers of updates. | |||
| #[inline] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed from applying callgrind on Materialize.