Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arranged methods for Threshold, Distinct and Count #324

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Kixiron
Copy link
Contributor

@Kixiron Kixiron commented May 4, 2021

Adds methods that return (arbitrary) arrangements for the threshold, distinct and count family of functions

@Kixiron
Copy link
Contributor Author

Kixiron commented Oct 14, 2021

Any updates on this PR?

@frankmcsherry
Copy link
Member

I'm sorry for the delay. I don't see this merging. It seems to primarily contain a number of "one-liners" that seem easy to handle in user code, without needing special support from the DD library itself. If that is wrong for any of these, please do call them out, but I believe most of these are wrappers around flavors of reduce_*, and if they are useful to your project 100% wrap them up as extension traits. But at the moment, I'd rather have a smaller public surface area to better manage expectations about what is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants